fetchgitlocal: fix permission problem #31937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it (nothing complicated, just basic usage), works fine for me. |
It was not possible to change the git index within the /nix/store/ so we copy the git folder in /tmp and operates on it via GTI_DIR.
teto
force-pushed
the
fetchgitlocal_pr
branch
from
48b3540
to
4d3fc8e
Compare
|
@volth sounds good but I don't find buitlins.exec in nixUnstable ? |
|
I believe nix 2.0 fetchGit makes this obsolete. Thus closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Attempt to make fetchgitLocal usable again; see #10873 and #31363
Things done
It was not possible to change the git index within the /nix/store/ so we
copy the git folder from /nix/store/ into /tmp and operates on it via GIT_DIR.
Would be cool if someone else could try it to make sure it works. Looked ok here on my project.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)